Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make readme image URL absolute #117

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Make readme image URL absolute #117

merged 2 commits into from
Dec 27, 2023

Conversation

Derpius
Copy link
Member

@Derpius Derpius commented Dec 27, 2023

Issue

No issue number. Caused by #116

Changes

Uses an absolute URL for the readme banner image

Impact

Fixes the banner image not displaying on NPM

Testing

n/a

Helpful Links

API Docs

Project Board

Discord

Copy link
Contributor

@yogwoggf yogwoggf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks correct to me, so this functions as a sort of QA too.

@Derpius Derpius merged commit 3610bb9 into master Dec 27, 2023
13 checks passed
@Derpius Derpius deleted the none-fix-readme-image branch December 27, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants