Increase ops when calling functions in most contexts #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Should resolve upstream issue wiremod#2958
Changes
ExprCall
andExprMethodCall
resolvers to add ops when calling functionsExprCall
user functions were adding opsImpact
Prevents calling functions an unlimited number of times (until hitting time quota, if enabled)
Testing
@strict
add ops equal to the cost of the function@strict
add ops equal to the cost of the function or15
if not defined,plus10
if the function is "legacy"2
if not defined2
if not defined, plus1
for being legacySomeVar:someFunction()
)Note that as I'm unfamiliar with the compiler, I'm unsure on the following two points:
What classes a function as "legacy"registerFunction
andlegacy
set to either undefined ortrue
in the optionsx or 123
checks were done for user functions already, which I've replicated