Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renames + better logging around republishing #191

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Conversation

decentralgabe
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 29.91914% with 260 lines in your changes are missing coverage. Please review.

Project coverage is 50.52%. Comparing base (2ba13d4) to head (876c256).
Report is 3 commits behind head on main.

Files Patch % Lines
impl/pkg/service/dht.go 20.38% 81 Missing and 1 partial ⚠️
impl/pkg/storage/db/bolt/bolt.go 33.02% 70 Missing and 3 partials ⚠️
impl/pkg/storage/db/postgres/postgres.go 18.30% 57 Missing and 1 partial ⚠️
impl/pkg/storage/db/postgres/queries.sql.go 24.24% 25 Missing ⚠️
impl/pkg/dht/record.go 64.70% 6 Missing ⚠️
impl/pkg/server/server.go 60.00% 3 Missing and 1 partial ⚠️
impl/pkg/server/dht.go 75.00% 2 Missing and 1 partial ⚠️
impl/pkg/storage/db/bolt/dht.go 57.14% 3 Missing ⚠️
impl/cmd/cli/identity.go 0.00% 2 Missing ⚠️
impl/concurrencytest/main.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   54.01%   50.52%   -3.49%     
==========================================
  Files          32       32              
  Lines        2540     2739     +199     
==========================================
+ Hits         1372     1384      +12     
- Misses       1029     1214     +185     
- Partials      139      141       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decentralgabe decentralgabe merged commit 09e4939 into main Apr 19, 2024
8 of 9 checks passed
@decentralgabe decentralgabe deleted the republish-logging branch April 19, 2024 23:37
decentralgabe pushed a commit that referenced this pull request Apr 22, 2024
* origin/main:
  remove migration and fix typos (#197)
  Bump github.com/miekg/dns from 1.1.58 to 1.1.59 in /impl (#194)
  fix republish and migration (#195)
  revert (#193)
  remove db migration (#192)
  Bump github.com/anacrolix/torrent from 1.52.5 to 1.55.0 in /impl (#187)
  Bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp (#184)
  renames + better logging around republishing (#191)
  Bump go.opentelemetry.io/contrib/instrumentation/runtime in /impl (#185)
  Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (#186)

# Conflicts:
#	impl/pkg/service/pkarr.go
#	spec/spec.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants