Add language around DID rotation; fix formatting #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2024 19:16
decentralgabe
requested review from
mistermoe,
finn-block,
csuwildcat and
frankhinek
as code owners
decentralgabe
commented
Apr 27, 2024
| [](https://github.com/TBD54566975/did-dht-method/issues/100) | ||
| Add guidance for rotating to a new DID after deactivation. | ||
| ::: | ||
| ### Rotation |
There was a problem hiding this comment.
pertinent bit here
impl/internal/did/did.go
Outdated
| @@ -62,6 +62,19 @@ func (d DHT) Suffix() (string, error) { | |||
| return "", fmt.Errorf("invalid did:dht prefix: %s", d) | |||
| } | |||
|
|
|||
| // IdentityKey returns the ed25519 public key for the DHT identifier | |||
There was a problem hiding this comment.
just a thought but you could link to the spec here in the doc comments https://did-dht.com/#identity-key
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 50.68% 50.49% -0.19%
==========================================
Files 32 32
Lines 2703 2713 +10
==========================================
Hits 1370 1370
- Misses 1194 1204 +10
Partials 139 139 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #100