This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
test: add ui tests for TransactionTile widget
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwlee
reviewed
Oct 15, 2024
| ], | ||
| ); | ||
|
|
||
| testWidgets('should show paying and payout currencies', (tester) async { |
There was a problem hiding this comment.
nit: should be payin instead of paying
There was a problem hiding this comment.
Thanks. Updating.
ethanwlee
reviewed
Oct 15, 2024
| void main() { | ||
| group('TransactionTile', () { | ||
| final pfi = TestData.getPfi('did:dht:pfiDid'); | ||
| const exchangeId = 'rfq_01ha835rhefwmagsknrrhvaa0k'; |
There was a problem hiding this comment.
is exchangeId being used for anything other than initializing transactionTileTestWidget? if not, this variable probably isn't necessary
There was a problem hiding this comment.
It's only used to initialize the TransactionTile widget.
I'll remove it the extra variable.
|
@ethan-tbd all current feedback have been addressed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UI tests for the
TransactionTilewidget.Closes #290.