fix: don't return a conflict when redeploying an identical deployment (…

…#492)
TBD54566975 · Oct 13, 2023 · 0f74f98 · 0f74f98
1 parent e689666
commit 0f74f98
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/backend/controller/controller.go b/backend/controller/controller.go
@@ -420,11 +420,11 @@ func (s *Service) ReplaceDeploy(ctx context.Context, c *connect.Request[ftlv1.Re
 			logger.Errorf(err, "Deployment not found: %s", newDeploymentName)
 			return nil, connect.NewError(connect.CodeNotFound, errors.New("deployment not found"))
 		} else if errors.Is(err, dal.ErrConflict) {
-			logger.Errorf(err, "Deployment already exists: %s", newDeploymentName)
-			return nil, connect.NewError(connect.CodeAlreadyExists, errors.WithStack(err))
+			logger.Infof("Deployment already exists: %s", newDeploymentName)
+		} else {
+			logger.Errorf(err, "Could not replace deployment: %s", newDeploymentName)
+			return nil, errors.Wrap(err, "could not replace deployment")
 		}
-		logger.Errorf(err, "Could not replace deployment: %s", newDeploymentName)
-		return nil, errors.Wrap(err, "could not replace deployment")
 	}
 	return connect.NewResponse(&ftlv1.ReplaceDeployResponse{}), nil
 }