Skip to content

Commit

Permalink
fix: pin buf protoc plugins (#523)
Browse files Browse the repository at this point in the history
Because we were not pinning, when a new version of a plugin was released
our builds would break because the git tree wasn't clean after a regen.
This fixes that.
  • Loading branch information
alecthomas authored Oct 26, 2023
1 parent 41e4cd8 commit 70c0271
Show file tree
Hide file tree
Showing 18 changed files with 22 additions and 18 deletions.
10 changes: 8 additions & 2 deletions Bitfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ SCHEMA_IN = backend/schema/schema.go backend/schema/protobuf.go \
cmd/ftl/cmd_schema.go
SCHEMA_OUT = protos/xyz/block/ftl/v1/schema/schema.proto

PROTO_IN = **/*.proto **/buf.*
PROTO_IN = **/*.proto **/buf.* bin/protoc* bin/buf
# There's no real way to mechanically generate the list of outputs, so we just
# explicitly list them here.
PROTO_OUT = protos/xyz/block/ftl/v1/ftlv1connect/ftl.connect.go \
Expand All @@ -20,7 +20,13 @@ PROTO_OUT = protos/xyz/block/ftl/v1/ftlv1connect/ftl.connect.go \
console/client/src/protos/xyz/block/ftl/v1/schema/schema_pb.ts \
console/client/src/protos/xyz/block/ftl/v1/schema/runtime_pb.ts \
console/client/src/protos/xyz/block/ftl/v1/ftl_pb.ts \
console/client/src/protos/xyz/block/ftl/v1/console/console_pb.ts
console/client/src/protos/xyz/block/ftl/v1/console/console_pb.ts \
console/client/src/protos/google/protobuf/timestamp_pb.ts \
console/client/src/protos/opentelemetry/proto/collector/metrics/v1/metrics_service_pb.ts \
console/client/src/protos/opentelemetry/proto/common/v1/common_pb.ts \
console/client/src/protos/opentelemetry/proto/metrics/v1/metrics_pb.ts \
console/client/src/protos/opentelemetry/proto/resource/v1/resource_pb.ts \
console/client/src/protos/opentelemetry/proto/trace/v1/trace_pb.ts

COMMON_LOG_IN = backend/common/log/api.go
COMMON_LOG_OUT = backend/common/log/log_level_string.go
Expand Down
File renamed without changes.
File renamed without changes.
1 change: 0 additions & 1 deletion bin/.protoc-gen-go-grpc-1.1.0.pkg

This file was deleted.

2 changes: 1 addition & 1 deletion bin/buf
2 changes: 1 addition & 1 deletion bin/protoc-gen-buf-breaking
2 changes: 1 addition & 1 deletion bin/protoc-gen-buf-lint
2 changes: 1 addition & 1 deletion bin/protoc-gen-connect-go
1 change: 0 additions & 1 deletion bin/protoc-gen-go-grpc

This file was deleted.

2 changes: 1 addition & 1 deletion console/client/src/protos/google/protobuf/timestamp_pb.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion console/client/src/protos/xyz/block/ftl/v1/ftl_connect.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions protos/buf.gen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ plugins:
- plugin: connect-go
out: .
opt: paths=source_relative
- plugin: buf.build/bufbuild/es
- plugin: buf.build/bufbuild/es:v1.4.0
out: ../console/client/src/protos
opt: target=ts
- plugin: buf.build/bufbuild/connect-es
- plugin: buf.build/connectrpc/es:v1.1.2
out: ../console/client/src/protos
opt: target=ts

0 comments on commit 70c0271

Please sign in to comment.