fix: generate kotlin deps transitively, always depend on "builtin" (#999

)

buildengine/build_kotlin.go

@@ -28,16 +28,12 @@ type externalModuleContext struct {
 }
 
 func (e externalModuleContext) ExternalModules() []*schema.Module {
-	depsSet := make(map[string]struct{})
-	for _, dep := range e.module.Dependencies {
-		depsSet[dep] = struct{}{}
-	}
-
-	modules := make([]*schema.Module, 0)
+	modules := make([]*schema.Module, 0, len(e.Modules))
 	for _, module := range e.Modules {
-		if _, exists := depsSet[module.Name]; exists || module.Name == "builtin" {
-			modules = append(modules, module)
+		if module.Name == e.module.Module {
+			continue
 		}
+		modules = append(modules, module)
 	}
 	return modules
 }
@@ -149,7 +145,7 @@ func generateExternalModules(ctx context.Context, module Module, sch *schema.Sch
 	return internal.ScaffoldZip(kotlinruntime.ExternalModuleTemplates(), config.Dir, externalModuleContext{
 		module: module,
 		Schema: sch,
-	}, scaffolder.Functions(funcs))
+	}, scaffolder.Exclude("^go.mod$"), scaffolder.Functions(funcs))
 }
 
 var scaffoldFuncs = scaffolder.FuncMap{

buildengine/deps.go

@@ -43,6 +43,16 @@ func UpdateDependencies(ctx context.Context, config moduleconfig.ModuleConfig) (
 	if err != nil {
 		return Module{}, err
 	}
+	containsBuiltin := false
+	for _, dep := range dependencies {
+		if dep == "builtin" {
+			containsBuiltin = true
+			break
+		}
+	}
+	if !containsBuiltin {
+		dependencies = append(dependencies, "builtin")
+	}
 	out := reflect.DeepCopy(config)
 	return Module{ModuleConfig: out, Dependencies: dependencies}, nil
 }

buildengine/engine_test.go

@@ -44,9 +44,10 @@ func TestEngine(t *testing.T) {
 	engine.Import(ctx, otherSchema)
 
 	expected := map[string][]string{
-		"alpha":   {"another", "other"},
-		"another": {},
+		"alpha":   {"another", "other", "builtin"},
+		"another": {"builtin"},
 		"other":   {},
+		"builtin": {},
 	}
 	graph, err := engine.Graph()
 	assert.NoError(t, err)