Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove type-specific Ref variants from schema #1074

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: remove type-specific Ref variants from schema #1074

merged 1 commit into from
Mar 13, 2024

Conversation

worstell
Copy link
Contributor

fixes #1043
fixes #1063

@alecthomas alecthomas mentioned this pull request Mar 13, 2024
Open
@alecthomas
Copy link
Collaborator

@worstell CI has failed, but it doesn't report it because of the autofmt...very irritating

@alecthomas
Copy link
Collaborator

alecthomas commented Mar 13, 2024 •
edited
Loading

If you run autofmt locally before you push it will fix this up.

@alecthomas
Copy link
Collaborator

Filed #1075

alecthomas
alecthomas approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good man

@worstell
Copy link
Contributor Author

If you run autofmt locally before you push it will fix this up.

the more you know!!!

@worstell worstell force-pushed the worstell/20240313-consolidate-refs branch from 9e2267a to 5ed8bca Compare March 13, 2024 23:04
@worstell worstell force-pushed the worstell/20240313-consolidate-refs branch from 5ed8bca to 96540ab Compare March 13, 2024 23:22
@worstell worstell merged commit 97f1b89 into main Mar 13, 2024
11 checks passed
@worstell worstell deleted the worstell/20240313-consolidate-refs branch March 13, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@dhanji dhanji Awaiting requested review from dhanji

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eradicate type-specific "Ref" variants in schema consolidate all typed refs into single generic ref
2 participants
@worstell @alecthomas