Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add startup prompt to extension #1301

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

wesbillman
Copy link
Member

@wesbillman wesbillman commented Apr 18, 2024

Fixes #1275
Fixes #1284

Screenshot 2024-04-18 at 7 24 14 AM

Also updated our icon
Screenshot 2024-04-18 at 8 03 43 AM

- clear diagnostic errors when extension is stopped
@wesbillman wesbillman requested a review from a team as a code owner April 18, 2024 14:45
@wesbillman wesbillman requested review from deniseli and removed request for a team April 18, 2024 14:45
@alecthomas alecthomas mentioned this pull request Apr 18, 2024
@wesbillman wesbillman changed the title fix: add starup prompt to extension fix: add startup prompt to extension Apr 18, 2024
@wesbillman wesbillman merged commit ba3c6e7 into main Apr 18, 2024
12 checks passed
@wesbillman wesbillman deleted the add-extension-startup-options branch April 18, 2024 15:11
Example:
```json
{
"ftl.executablePath": "bin/ftl"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the trailing `

@deniseli deniseli added the approved Marks an already closed PR as approved label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting to extension to control "auto start" Extension should clear errors before restart
2 participants