feat: IAM Auth for RDS #3559
Merged
feat: IAM Auth for RDS #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
requested review from
stuartwdouglas
and removed request for
a team
stuartwdouglas
approved these changes
Nov 28, 2024
alecthomas
approved these changes
Nov 28, 2024
| } | ||
|
|
||
| authenticationToken, err := auth.BuildAuthToken( | ||
| // TODO: proper region |
There was a problem hiding this comment.
Will be done very soon!
|
|
||
| Username string `parser:"" protobuf:"2"` | ||
| Endpoint string `parser:"" protobuf:"3"` | ||
| Database string `parser:"" protobuf:"4"` |
There was a problem hiding this comment.
We don't want this to be parseable?
There was a problem hiding this comment.
Hmm, that is just cargo culting from the existing runtime, and it seems to work. Not totally sure what this does. Should these be parseable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have not been yet fully test e2e, but at least this creates the user with right auth mechanism.
Merging this in will help testing, as I won't need to keep manual docker images in sync.