Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

set default key id as jwk thumbprint #488

Merged
merged 2 commits into from
Nov 21, 2023
Merged

set default key id as jwk thumbprint #488

merged 2 commits into from
Nov 21, 2023

Conversation

decentralgabe
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Merging #488 (27587f8) into main (22beff9) will decrease coverage by 0.18%.
The diff coverage is 41.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   57.28%   57.10%   -0.18%     
==========================================
  Files          67       67              
  Lines        7509     7540      +31     
==========================================
+ Hits         4301     4305       +4     
- Misses       2472     2490      +18     
- Partials      736      745       +9     
Files Coverage Δ
credential/integrity/signature.go 78.30% <100.00%> (ø)
crypto/jwx/jwt.go 54.63% <100.00%> (ø)
cryptosuite/jws2020/jsonwebkey2020.go 46.76% <100.00%> (ø)
did/ion/operations.go 50.30% <100.00%> (ø)
did/jwk/jwk.go 77.45% <100.00%> (ø)
did/util.go 31.63% <0.00%> (ø)
crypto/jwx/jwk.go 52.72% <25.00%> (-2.88%) ⬇️

@decentralgabe decentralgabe merged commit c496504 into main Nov 21, 2023
5 checks passed
@decentralgabe decentralgabe deleted the default-kid branch November 21, 2023 02:37
@andresuribe87
Copy link
Contributor

Missed this @decentralgabe ... can you explain the motivation behind this change?

@decentralgabe
Copy link
Member Author

@andresuribe87 keep in line with the other sdks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants