Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

add balance vector #301

Merged
merged 1 commit into from
Mar 28, 2024
Merged

add balance vector #301

merged 1 commit into from
Mar 28, 2024

Conversation

kirahsapong
Copy link
Contributor

nitro-neal
nitro-neal reviewed Mar 28, 2024
View reviewed changes
hosted/test-vectors/protocol/vectors/parse-balance.json
@@ -0,0 +1,19 @@
{
"description": "Balance parses from string",
"input": "{\"metadata\":{\"from\":\"did:dht:t6gdbr4qs95b4j6pbdxe4rzp41am735pm9c65135gajusam9xx8o\",\"kind\":\"balance\",\"id\":\"balance_01ht38w02ae2kbhwbcakmnp8qb\",\"createdAt\":\"2024-03-28T19:33:56.938Z\",\"protocol\":\"1.0\"},\"data\":{\"currencyCode\":\"USD\",\"available\":\"400.00\"},\"signature\":\"eyJhbGciOiJFZERTQSIsImtpZCI6ImRpZDpkaHQ6dDZnZGJyNHFzOTViNGo2cGJkeGU0cnpwNDFhbTczNXBtOWM2NTEzNWdhanVzYW05eHg4byMwIn0..t-cVr4Djf9APYgEESNd4BO7DX6HMGd8KRzm_7sFP_oba4Ngh16BMagx_IBDcZJyeEKlUD51CdUy-ffJ4WWH_AQ\"}",
Copy link

@nitro-neal nitro-neal Mar 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the other test vectors escaped like this? I think you can make this a normal json object and not escaped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the intent of this vector is specific to parsing from a string to the object

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes https://github.com/TBD54566975/tbdex/blob/main/hosted/test-vectors/protocol/vectors/parse-close.json

nitro-neal
nitro-neal approved these changes Mar 28, 2024
View reviewed changes
Copy link

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on escaped json object

@kirahsapong kirahsapong merged commit 2fed068 into main Mar 28, 2024
@kirahsapong kirahsapong deleted the feat/add-balance-vector branch March 28, 2024 20:45
diehuxx pushed a commit that referenced this pull request Mar 29, 2024
Merge branch 'main' into rfq-private-salt
ac3e3e7 
* main:
  updating parse close vector with success field (#304)
  Refresh offerings test vector (#303)
  add balance vector (#301)
  Rip out List Offering query params (#302)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@nitro-neal nitro-neal nitro-neal approved these changes

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@jiyoonie9 jiyoonie9 Awaiting requested review from jiyoonie9

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

@diehuxx diehuxx Awaiting requested review from diehuxx

@decentralgabe decentralgabe Awaiting requested review from decentralgabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirahsapong @KendallWeihe @nitro-neal