-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for new Visibilities object and some tidy #124
Conversation
samaloney
commented
Jun 2, 2024
- Upate internal code for new vis object
- Update imaging demo to use new vis object feature (slice, meta)
- Small tidy ups
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 72.57% 72.30% -0.28%
==========================================
Files 31 31
Lines 1856 1892 +36
==========================================
+ Hits 1347 1368 +21
- Misses 509 524 +15 ☔ View full report in Codecov by Sentry. |
rotation_angle=90 * u.deg + roll, | ||
) | ||
|
||
clean_map = Map((clean_map.data, header)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the map created outside of clean? Is it possible to make it inside as for the other methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently vis_clean
makes a map assuming helioprojective which in this case is not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially once TCDSolar/xrayvision/issues/56 is done issue is resolved this won't be necessary