Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new Visibilities object and some tidy #124

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

samaloney
Copy link
Member

  • Upate internal code for new vis object
  • Update imaging demo to use new vis object feature (slice, meta)
  • Small tidy ups

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 47.45763% with 31 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (2854ed9) to head (a847cc3).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
stixpy/calibration/visibility.py 43.58% 22 Missing ⚠️
stixpy/imaging/em.py 55.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   72.57%   72.30%   -0.28%     
==========================================
  Files          31       31              
  Lines        1856     1892      +36     
==========================================
+ Hits         1347     1368      +21     
- Misses        509      524      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney samaloney requested a review from paolomassa June 3, 2024 06:08
rotation_angle=90 * u.deg + roll,
)

clean_map = Map((clean_map.data, header))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the map created outside of clean? Is it possible to make it inside as for the other methods?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently vis_clean makes a map assuming helioprojective which in this case is not correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially once TCDSolar/xrayvision/issues/56 is done issue is resolved this won't be necessary

@samaloney samaloney merged commit 9315811 into TCDSolar:main Jun 8, 2024
11 of 13 checks passed
@samaloney samaloney deleted the tidy-vis-creatation branch June 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants