Fix bug in the default creation of VisMeta (#66)

* Fixed bug in the default creation of VisMeta * Add changelog file * Fix changelog
TCDSolar · May 28, 2024 · dcd2a3e · dcd2a3e
1 parent 6fde63d
commit dcd2a3e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/changelog/66.bugfix.rst b/changelog/66.bugfix.rst
@@ -0,0 +1 @@
+Fix bug when creating :class:`~xrayvision.visibility.Visibilities` with default meta.
diff --git a/xrayvision/visibility.py b/xrayvision/visibility.py
@@ -285,10 +285,6 @@ def __init__(
         self._uv_key = "uv"
         self._units_key = "units"
 
-        # Build meta. Make sure that phase center is included.
-        if not isinstance(meta, VisMetaABC):
-            meta = VisMeta(meta)
-
         # Construct underlying data object.
         dims = [f"dim{i}" for i in range(0, len(visibilities.shape))]
         dims[_uv_axis] = self._uv_key
@@ -307,7 +303,7 @@ def __init__(
         if phase_uncertainty is not None:
             data[self._phase_uncert_key] = (dims, phase_uncertainty.to_value(phase.unit))
         if meta is None:
-            meta = VisMeta(dict())
+            meta = VisMeta()
         vis_labels = getattr(meta, "vis_labels", None)
         if vis_labels is not None:
             if len(vis_labels) != nvis:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug when creating :class:`~xrayvision.visibility.Visibilities` with default meta.