Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index_by_label method to Visibilities class #65

Merged
merged 71 commits into from
May 27, 2024

Conversation

DanRyanIrish
Copy link
Contributor

@DanRyanIrish DanRyanIrish commented May 25, 2024

DO NOT MERGE UNTIL #64 is merged.

This PR adds an index_by_label method to Visibilities which allows a subset of visibilities to be copied into a new Visibilities instance based on their Visibilities.meta.vis_labels values. It also adds a __getitem__ method so it can be sliced with the standard slicing API.

This method could potentially be added to the VisibilitiesABC, but I don't think that discussion needs to hold up this PR.

annavolp and others added 30 commits April 29, 2024 18:23
Make underlying data structure for Visibilities class an xarray
@DanRyanIrish DanRyanIrish marked this pull request as draft May 25, 2024 09:38
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@adfb913). Learn more about missing BASE report.

Files Patch % Lines
xrayvision/visibility.py 90.62% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage        ?   89.04%           
=======================================
  Files           ?        7           
  Lines           ?      904           
  Branches        ?        0           
=======================================
  Hits            ?      805           
  Misses          ?       99           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xrayvision/visibility.py Outdated Show resolved Hide resolved
xrayvision/visibility.py Show resolved Hide resolved
@samaloney samaloney marked this pull request as ready for review May 27, 2024 10:48
@samaloney samaloney merged commit 6fde63d into TCDSolar:main May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants