-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index_by_label method to Visibilities class #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DanRyanIrish <[email protected]>
Make underlying data structure for Visibilities class an xarray
Update Vis class PR
Update Vis_class PR (Part 2)
Co-authored-by: DanRyanIrish <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage ? 89.04%
=======================================
Files ? 7
Lines ? 904
Branches ? 0
=======================================
Hits ? 805
Misses ? 99
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samaloney
reviewed
May 26, 2024
samaloney
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL #64 is merged.
This PR adds an
index_by_label
method toVisibilities
which allows a subset of visibilities to be copied into a newVisibilities
instance based on theirVisibilities.meta.vis_labels
values. It also adds a__getitem__
method so it can be sliced with the standard slicing API.This method could potentially be added to the
VisibilitiesABC
, but I don't think that discussion needs to hold up this PR.