-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make software compatible with Visibilities class #67
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage ? 89.43%
=======================================
Files ? 7
Lines ? 890
Branches ? 0
=======================================
Hits ? 796
Misses ? 94
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks ok - do the demos make ok images? Also does this version work with the stixpy as in do the images look ok.
The test fails are from the examples need to update the examples too and make sure the images also look the same before and after. |
Co-authored-by: Shane Maloney <[email protected]>
Co-authored-by: Shane Maloney <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @paolomassa
First version of the modifications needed to make the software compatible with the
Visibilities
class