[fix] #196 - promotion 조회 로직 수정 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hoonyworld
approved these changes
Aug 29, 2024
Comment on lines
+223
to
+226
| Long performanceId = null; | ||
| if (promotion.getPerformance() != null) { | ||
| performanceId = promotion.getPerformance().getId(); | ||
| } |
There was a problem hiding this comment.
확실히 getPerformance()가 null일 때, getId()를 하게 되면 NullPointerException이 발생해 500에러가 발생하는 것 같습니다.
이를 promotion.getPerformance()시 null이 아닐때만 getId()를 하도록 하신 점 너무 잘하신 것 같습니다!
고생하였습니다~
There was a problem hiding this comment.
감사합니다ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
performanceId가 null인 promotion이 db에 삽입됐을 때 홈페이지 조회가 안되는 이슈가 있었습니다.
PerformanceService의 getPromotions 로직에서 performanceId가 null인 경우를 고려하지 않아 발생한 이슈였기 때문에 performanceId가 null이 아닌 경우에만 promotion.getPerformance().getId()로 performanceId를 조회하는 로직으로 수정했습니다.
Trouble Shooting ⚽️
Related ScreenShot 📷
performanceId가 null인 promotionId 9번의 promotion을 포함한 promotionList가 정상적으로 조회되며, performanceList도 같이 잘 조회되는 것을 확인했습니다.
Uncompleted Tasks 😅
To Reviewers 📢