Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #204 - SuccessReponse 메서드 타입 수정 및 회원 예매 조회 타입 일치 완료 #205

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[fix] #204 - SuccessReponse 메서드 타입 수정 및 회원 예매 조회 타입 일치 완료 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f7dad4
[#204] fix(SuccessResponse): 메서드에 제네릭 타입 명시
hoonyworld Aug 31, 2024
4b5baa7
[#204] fix(BookingController): 회원 예매 조회 response 타입 일치하도록 수정
hoonyworld Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/beat/domain/booking/api/BookingController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public ResponseEntity<SuccessResponse<MemberBookingResponse>> createMemberBookin

@Operation(summary = "회원 예매 조회 API", description = "회원이 예매를 조회하는 GET API입니다.")
@GetMapping("/member/retrieve")
public ResponseEntity<SuccessResponse<MemberBookingRetrieveResponse>> getMemberBookings(
public ResponseEntity<SuccessResponse<List<MemberBookingRetrieveResponse>>> getMemberBookings(
@CurrentMember Long memberId) {
List<MemberBookingRetrieveResponse> response = memberBookingRetrieveService.findMemberBookings(memberId);
return ResponseEntity.status(HttpStatus.OK)
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/beat/global/common/dto/SuccessResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ public record SuccessResponse<T>(
String message,
T data
) {
public static <T> SuccessResponse of(final BaseSuccessCode baseSuccessCode, final T data) {
return new SuccessResponse(baseSuccessCode.getStatus(), baseSuccessCode.getMessage(), data);
public static <T> SuccessResponse<T> of(final BaseSuccessCode baseSuccessCode, final T data) {
return new SuccessResponse<>(baseSuccessCode.getStatus(), baseSuccessCode.getMessage(), data);
}

public static SuccessResponse from(final BaseSuccessCode baseSuccessCode) {
return new SuccessResponse(baseSuccessCode.getStatus(), baseSuccessCode.getMessage(), null);
public static <T> SuccessResponse<T> from(final BaseSuccessCode baseSuccessCode) {
return new SuccessResponse<>(baseSuccessCode.getStatus(), baseSuccessCode.getMessage(), null);
}
}
Loading