Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat ] 온보딩, 선배프로필 등록 데이터 연결 및 디자인 QA 반영 #295

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Oct 21, 2024

#️⃣ Related Issue

Closes #294

✅ Done Task

  • 온보딩, 선배프로필 등록 데이터 연결 (온보딩을 거치지 않으면 루트 경로로 이동합니다)
  • 선배 카드 헤더 구분선 추가 및 content 간격 조정
  • 리뷰보기 내부 텍스트 중앙 정렬

💎 PR Point

  • 데이터 연결하는 부분은 온보딩을 거칠 수가 없어서 (이미 가입된 계정이라) 스크린샷을 남길 수가 없습니당

📸 Screenshot

  • 헤더 구분선 추가 및 content 간격 조정
    image

  • 리뷰보기 중앙정렬
    image

@j-nary j-nary added ✨ Feat 새로운 기능 추가 (새로운 구현) labels Oct 21, 2024
@j-nary j-nary self-assigned this Oct 21, 2024
@j-nary j-nary requested a review from se0jinYoon October 21, 2024 15:39
@j-nary j-nary requested a review from yarimu October 21, 2024 15:39
@j-nary j-nary changed the title [ Feat ] 온보딩, 선배프로필 등록 데이터 연결 [ Feat ] 온보딩, 선배프로필 등록 데이터 연결 및 디자인 QA 반영 Oct 21, 2024
Copy link
Collaborator

@se0jinYoon se0jinYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요~ 코멘트 하나만 확인해주쇼~

top: 4.9rem;

width: 100%;
height: 1.4px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2) 얜 왜 Px이에요? 린트 에러 안났나?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 안 나더라구용! rem으로 바꾸고 머지하겠슴당 ~!

@j-nary j-nary merged commit 1026d4b into develop Oct 29, 2024
1 check passed
@j-nary j-nary deleted the feat/#294/senior-profile-data branch October 29, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 새로운 기능 추가 (새로운 구현) size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feat ] 온보딩, 선배프로필 데이터 연결
2 participants