Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Design ] 랜딩페이지 로띠 gif로 변경 #307

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

se0jinYoon
Copy link
Collaborator

@se0jinYoon se0jinYoon commented Oct 28, 2024

#️⃣ Related Issue

Closes #305

✅ Done Task

  • �랜딩페이지 로띠 gif로 변경

☀️ New-insight

  • 저희 랜딩페이지 로띠 사이즈가 너무 커서 제거하고 gif로 변경 작업했습니다~

💎 PR Point

📸 Screenshot

[데웹]

2024-10-28.10.52.57.mov

[모웹]
마지막 갤럭시 s8은 저희가 최소 사이즈로 잡은 SE보다 가로길이가 작아서 깨지네요 .. (방금 처음봄)
근데 S8이제 안쓰지 않을까? 라고 생각하고 일단 엣지케이스로 남겨둘게요 ..

2024-10-28.10.53.55.mov

@se0jinYoon se0jinYoon added 💄 Design 스타일 구현 서진 labels Oct 28, 2024
@se0jinYoon se0jinYoon requested review from j-nary and ijieun October 28, 2024 13:56
@se0jinYoon se0jinYoon self-assigned this Oct 28, 2024
Copy link
Collaborator

@j-nary j-nary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Collaborator

@ijieun ijieun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@se0jinYoon se0jinYoon merged commit efd5335 into develop Oct 30, 2024
1 check passed
@se0jinYoon se0jinYoon deleted the design/#305/landingLottieGif branch October 30, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[ Design ] 랜딩페이지 로띠 gif로 변경
3 participants