[ Feat ] 2차 QA 모달 추가 #317
Merged
[ Feat ] 2차 QA 모달 추가 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ refactor ] vercel 배포 테스트 main merge
배포 테스트 - 코드 스플릿팅 제거
[ main merge ] 코드 스플리팅 추가, 빌드 모듈 분리
j-nary
approved these changes
Oct 29, 2024
| } else if (nav === '나의 약속') { | ||
| switch (nav) { | ||
| case '둘러보기': | ||
| userRole === 'JUNIOR' ? setCurrNav('/juniorPromise') : setShowModal(true); |
There was a problem hiding this comment.
p5) 해당 조건문 자주 쓰이니까 const isJunior = userRole === 'JUNIOR'로 해줘도 좋을 것 같슴당 !
Comment on lines
+4
to
+7
| const baseUrl = import.meta.env.VITE_APP_API_BASE_URL; | ||
|
|
||
| export const axios = _axios.default.create({ | ||
| baseURL: '/api', | ||
| baseURL: `${baseUrl}`, |
There was a problem hiding this comment.
웅 맞긴한데 왜 이 브랜치 피알에 있나했어 ㅋㅋ ㅜ
ijieun
approved these changes
Oct 30, 2024
src/components/commons/Nav.tsx
Outdated
| <AutoCloseModal | ||
| text="아직 준비중인 기능이에요" | ||
| showModal={showModal} | ||
| handleShowModal={(type: boolean) => setShowModal(type)}> |
There was a problem hiding this comment.
P5) 네이밍을 type대신 show처럼 명확하게 바꾸면 좋을거 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #314
✅ Done Task
☀️ New-insight
2차 큐에이하면서 필요할 것 같아서 모달 추가 요청했어요.
💎 PR Point
헤더에 '알림은 문자를 확인해주세요' -> 그래픽 픽스가 안돼서 일단 제가 임의로 넣어놨어요! 기디한테 픽스 받으면 반영해두겠습니당~
📸 Screenshot
[헤더 모달]
2024-10-29.6.16.05.mov
[Nav 모달]
2024-10-29.6.16.32.mov
2024-10-29.6.17.11.mov