Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix] PresignedURL API 주소 수정 및 pointer cursor 추가 #327

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

lydiacho
Copy link
Collaborator

#️⃣ Related Issue

Closes #325

✅ Done Task

  • 온보딩 cursor pointer 일괄 추가
  • 프사유 주소 앞에 /api 가 안붙어서 오류 발생하는 이슈

💎 PR Point

지은이 제안대로 온보딩에 있는 모든 클릭 영역 다 cursor: pointer 처리 추가해주었습니다!

그리고 머지한 PR 다 pull 당겨서 develop에서 한번 테스트해보는데 presignedurl API에서 오류나길래
뭐지... 했는데 url에 /api 가 빠져있어서 에러가 난거더라구요? 그래서 붙여줬습니다 . .
근데 아까는 분명됐었는데 어케 된건지 의문 . .
아마 깃헙에서 컨플릭트 수정해서 머지하다가 뭔가 잘못 지워진 것 같아용

@lydiacho lydiacho requested review from ijieun and se0jinYoon October 30, 2024 15:00
@lydiacho lydiacho self-assigned this Oct 30, 2024
Copy link
Collaborator

@ijieun ijieun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르다. . .

@lydiacho lydiacho merged commit a81b996 into develop Oct 30, 2024
1 check passed
@lydiacho lydiacho deleted the fix/#325/cursorUrl branch October 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Fix ] cursor pointer 추가 및 presignedurl 주소 오탈자 수정
3 participants