[ Design ] 선배 프로필 헤더 수정 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se0jinYoon
reviewed
Nov 12, 2024
| const Divider = styled.div` | ||
| position: fixed; | ||
| top: 5rem; | ||
| z-index: 1; |
There was a problem hiding this comment.
p1) 여긴 z-index가 있고 JuniorPromisePage의 Divider에는 z-index가 없는 이유가 몬가요?
There was a problem hiding this comment.
JuniorPromiseRequestPage에는 선배 이름을 보여주는 Banner 컴포넌트가 한 겹 더 있기 때문입니다!! 따라서 z-index를 주어야 표시가 되길래 넣어줬습니다!
lydiacho
reviewed
Nov 18, 2024
| @@ -270,3 +272,12 @@ const GrayLine2 = styled.div` | |||
|
|
|||
| background-color: ${({ theme }) => theme.colors.grayScaleWG}; | |||
| `; | |||
|
|
|||
| const Divider = styled.div` | |||
There was a problem hiding this comment.
p4) div 도 좋지만 구분선에 쓰이는 hr 이라는 태그도 있답니당 !_!
참고 참고 ~~
lydiacho
approved these changes
Nov 18, 2024
se0jinYoon
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #354
✅ Done Task
☀️ New-insight
💎 PR Point
공통 컴포넌트 Header에 title 속성을 추가하여 피그마와 동일하게 헤더를 수정하고, 하단에 선을 추가했습니다.
📸 Screenshot