Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: criação do teste do metodo FormatInstant #12478

Closed
wants to merge 1 commit into from
Closed

Test: criação do teste do metodo FormatInstant #12478

wants to merge 1 commit into from

Conversation

igorpenhaa
Copy link

@igorpenhaa igorpenhaa commented Jun 17, 2023

Producing new tests #8557

Fixes #8557

Outline of Solution

increasing code coverage

fault identification: the LocalDateTime method is tested with the default of the developer's machine.

@github-actions
Copy link

Hi @igorpenhaa, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@weiquu
Copy link
Contributor

weiquu commented Jun 18, 2023

Hi @igorpenhaa, ignoring the failing lint tests, I don't think this PR actually addresses the issue raised in #8557

The issue is that there are tests which fail if the system locale is set to a locale that uses different date/decimal formats. I set my system locale to Germany and ran ./gradlew componentTests which resulted in this failed test:
Screenshot 2023-06-18 at 22 04 32

In contrast, all tests passed when I reset my system locale back to Singapore.

Your PR seems to be adding tests to the TimeHelper util, but I don't think it actually increases the code coverage. Do let me know if I have misunderstood.

@zhaojj2209
Copy link
Contributor

Closing as PR does not address issue, see above.

@zhaojj2209 zhaojj2209 closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: certain tests are locale-dependent
3 participants