[#12048] Migrate tests for GetAccountsAction.java #13214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyang143
force-pushed
the
branch-migrate-tests-week4-1
branch
from
0ecedd6 to
d61759d
Compare
dishenggg
requested changes
Feb 11, 2025
Comment on lines
+36
to
+37
| Account accountStub = typicalAccount; | ||
| Account anotherAccountStub = new Account(accountStub.getGoogleId(), accountStub.getEmail(), accountStub.getName()); |
There was a problem hiding this comment.
This creates 2 accounts with the same googleId which should not happen in the real world, although this wouldnt affect the execution of the test case lets change the anotherAccountStub to have different attributes to better reflect actual data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Change GetAccountsActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.