Testing: Improve instructions and process #8844

.templates/ideaRunConfigurations/CI_Tests.xml

@@ -7,8 +7,8 @@
       </pattern>
     </extension>
     <module name="" />
-    <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" />
-    <option name="ALTERNATIVE_JRE_PATH" value="1.8" />
+    <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="false" />
+    <option name="ALTERNATIVE_JRE_PATH" />
     <option name="SUITE_NAME" value="$PROJECT_DIR$/src/test/testng-ci.xml" />
     <option name="PACKAGE_NAME" value="" />
     <option name="MAIN_CLASS_NAME" value="" />
@@ -25,7 +25,7 @@
     <option name="TEST_SEARCH_SCOPE">
       <value defaultName="wholeProject" />
     </option>
-    <option name="USE_DEFAULT_REPORTERS" value="false" />
+    <option name="USE_DEFAULT_REPORTERS" value="true" />
     <option name="PROPERTIES_FILE" value="" />
     <envs />
     <properties />

.templates/ideaRunConfigurations/Failed_Tests.xml

@@ -2,8 +2,8 @@
   <configuration default="false" name="Failed Tests" type="TestNG" factoryName="TestNG">
     <extension name="coverage" enabled="false" merge="false" sample_coverage="true" runner="idea" />
     <module name="" />
-    <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" />
-    <option name="ALTERNATIVE_JRE_PATH" value="1.8" />
+    <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="false" />
+    <option name="ALTERNATIVE_JRE_PATH" />
     <option name="SUITE_NAME" value="$PROJECT_DIR$/test-output/testng-failed.xml" />
     <option name="PACKAGE_NAME" value="" />
     <option name="MAIN_CLASS_NAME" value="" />
@@ -20,7 +20,7 @@
     <option name="TEST_SEARCH_SCOPE">
       <value defaultName="wholeProject" />
     </option>
-    <option name="USE_DEFAULT_REPORTERS" value="false" />
+    <option name="USE_DEFAULT_REPORTERS" value="true" />
     <option name="PROPERTIES_FILE" value="" />
     <envs />
     <properties />

.templates/ideaRunConfigurations/Local_Tests.xml

@@ -2,8 +2,8 @@
   <configuration default="false" name="Local Tests" type="TestNG" factoryName="TestNG">
     <extension name="coverage" enabled="false" merge="false" sample_coverage="true" runner="idea" />
     <module name="" />
-    <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" />
-    <option name="ALTERNATIVE_JRE_PATH" value="1.8" />
+    <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="false" />
+    <option name="ALTERNATIVE_JRE_PATH" />
     <option name="SUITE_NAME" value="$PROJECT_DIR$/src/test/testng-local.xml" />
     <option name="PACKAGE_NAME" value="" />
     <option name="MAIN_CLASS_NAME" value="" />
@@ -20,7 +20,7 @@
     <option name="TEST_SEARCH_SCOPE">
       <value defaultName="wholeProject" />
     </option>
-    <option name="USE_DEFAULT_REPORTERS" value="false" />
+    <option name="USE_DEFAULT_REPORTERS" value="true" />
     <option name="PROPERTIES_FILE" value="" />
     <envs />
     <properties />

docs/development.md

@@ -137,7 +137,7 @@ Before running tests, modify `src/test/resources/test.properties` if necessary,
 
 ### Using Firefox
 
-* Only Firefox between versions 38.0.5 and 46.0.1 are supported.
+* Only Firefox between versions 38.0.5 and 46.0.0 are supported.
   * To downgrade your Firefox version, obtain the executable from [here](https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/).
   * If you want to use a different path for this version, choose `Custom setup` during install.
   * Remember to disable the auto-updates (`Options → Advanced tab → Update`).

src/main/java/teammates/common/datatransfer/questions/FeedbackConstantSumQuestionDetails.java

@@ -1,6 +1,5 @@
 package teammates.common.datatransfer.questions;
 
-import java.text.DecimalFormat;
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.HashMap;
@@ -447,8 +446,6 @@ public String getQuestionResultStatisticsHtml(
 
         Map<String, List<Integer>> optionPoints = generateOptionPointsMapping(responses);
 
-        DecimalFormat df = new DecimalFormat("#.##");
-
         Map<String, List<Integer>> sortedOptionPoints = new TreeMap<>();
 
         Map<String, String> identifierMap = new HashMap<>();
@@ -475,14 +472,14 @@ public String getQuestionResultStatisticsHtml(
                         Slots.TEAM, SanitizationHelper.sanitizeForHtml(teamName),
                         Slots.CONSTSUM_POINTS_RECEIVED, pointsReceived,
                         Slots.CONSTSUM_TOTAL_POINTS, Integer.toString(total),
-                        Slots.CONSTSUM_AVERAGE_POINTS, df.format(average)));
+                        Slots.CONSTSUM_AVERAGE_POINTS, StringHelper.toDecimalFormatString("#.##", average)));
             } else {
 
                 fragments.append(Templates.populateTemplate(FormTemplates.CONSTSUM_RESULT_STATS_OPTIONFRAGMENT,
                         Slots.CONSTSUM_OPTION_VALUE, SanitizationHelper.sanitizeForHtml(option),
                         Slots.CONSTSUM_POINTS_RECEIVED, pointsReceived,
                         Slots.CONSTSUM_TOTAL_POINTS, Integer.toString(total),
-                        Slots.CONSTSUM_AVERAGE_POINTS, df.format(average)));
+                        Slots.CONSTSUM_AVERAGE_POINTS, StringHelper.toDecimalFormatString("#.##", average)));
             }
         });
 
@@ -509,8 +506,6 @@ public String getQuestionResultStatisticsCsv(
         List<String> options = constSumOptions;
         Map<String, List<Integer>> optionPoints = generateOptionPointsMapping(responses);
 
-        DecimalFormat df = new DecimalFormat("#.##");
-
         Map<String, List<Integer>> sortedOptionPoints = new TreeMap<>();
 
         Map<String, String> identifierMap = new HashMap<>();
@@ -538,8 +533,8 @@ public String getQuestionResultStatisticsCsv(
             double total = computeTotal(points);
 
             fragments.append(option)
-                    .append(',').append(df.format(average))
-                    .append(',').append(df.format(total))
+                    .append(',').append(StringHelper.toDecimalFormatString("#.##", average))
+                    .append(',').append(StringHelper.toDecimalFormatString("#.##", total))
                     .append(',').append(StringHelper.join(",", points))
                     .append(System.lineSeparator());