Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8844] Testing: Improve instructions and process #8988

Closed
wants to merge 8 commits into from

Conversation

tshradheya
Copy link
Member

Fixes #8844

Outline of Solution

  • Made default reported being true so that its standardized for IntelliJ
  • Ensured tests are not locale-dependent
  • Corrected minor problem in documentation

@LiHaoTan Need input on this #8977 (comment)

NOTE: Continued from #8845 as I messed up the old PR :P

@tshradheya tshradheya added the s.ToReview The PR is waiting for review(s) label Jul 26, 2018
@tshradheya tshradheya requested a review from LiHaoTan July 27, 2018 02:32
@LiHaoTan
Copy link
Contributor

@tshradheya you haven't addressed the comments: #8977

@LiHaoTan LiHaoTan self-assigned this Aug 10, 2018
@LiHaoTan LiHaoTan added s.Ongoing The PR is being worked on by the author(s) and removed s.ToReview The PR is waiting for review(s) labels Aug 10, 2018
@tshradheya
Copy link
Member Author

With regard to this: #8977 (comment)

I am not sure how to return a TeammatesDateTimeFormatter and use that for calling the DateTimeFormatter methods by wrapping them

@LiHaoTan
Copy link
Contributor

For example something like this:

public class TeammatesDateTimeFormatter {
    private DateTimeFormatter formatter;

    private TeammatesDateTimeFormatter(DateTimeFormatter formatter) {
        this.formatter = formatter;
    }

    public static TeammatesDateTimeFormatter ofPattern(String pattern) {
        return new TeammatesDateTimeFormatter(DateTimeFormatter.ofPattern(pattern, Locale.US));
    }

    public String format(TemporalAccessor temporal) {
        return formatter.format(temporal);
    }
}

@wkurniawan07 wkurniawan07 changed the title Testing: Improve instructions and process #8844 [#8844] Testing: Improve instructions and process Aug 27, 2018
@tshradheya tshradheya closed this Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants