Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradebook audit new dm test cbini #2356

Merged
merged 30 commits into from
Jan 17, 2025

Conversation

cbini
Copy link
Member

@cbini cbini commented Jan 6, 2025

Pull Request

Summary & Motivation

Self-review

If this is a same-day request, please flag that in our Slack channel!

  • Update due date, assignee, and priority on our
    TEAMster Asana Project
  • Format has been run on all modified files

SQL

  • Ensure you are using the union_dataset_join_clause() macro for queries that employ any
    models using these datasets: deanslist edplan iready overgrad pearson powerschool
    renlearn titan

  • All distinct usage must be accompanied by an comment explaining it's necessity

  • If you are adding a new external source, run:

    dbt run-operation stage_external_sources --vars
    "ext_full_refresh: true"
    

Troubleshooting

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@cbini cbini requested review from a team as code owners January 6, 2025 21:58
@cbini cbini requested review from GabyRangelB and removed request for a team January 16, 2025 17:00
@cbini cbini assigned cbini and unassigned cbini Jan 16, 2025
@cbini
Copy link
Member Author

cbini commented Jan 16, 2025

@TEAMSchools/analytics-engineers FYI this PR renames:

  • int_tableau__student_enrollments to int_extracts__student_enrollments
  • int_reporting__student_filters to int_extracts__student_enrollments_subjects

int_extracts__student_enrollments_subjects is derived from int_extracts__student_enrollments, which is derived from base_powerschool__student_enrollments. We should refactor any joins to int_extracts__student_enrollments_subjects in the future for performance.

@cbini cbini linked an issue Jan 16, 2025 that may be closed by this pull request
@cbini cbini merged commit 2553107 into gradebook_audit_new_dm_test Jan 17, 2025
2 checks passed
@cbini cbini deleted the gradebook_audit_new_dm_test-cbini branch January 17, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we add an actual end of quarter field to terms?
2 participants