Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick psat table swap for grad requirements #2470

Open
wants to merge 82 commits into
base: main
Choose a base branch
from
Open

Quick psat table swap for grad requirements #2470

wants to merge 82 commits into from

Conversation

GabyRangelB
Copy link
Contributor

@GabyRangelB GabyRangelB commented Feb 20, 2025 •
edited by cbini
Loading

Pull Request

Summary & Motivation

Self-review

If this is a same-day request, please flag that in our Slack channel!

  • Update due date, assignee, and priority on our
    TEAMster Asana Project
  • Format has been run on all modified files

SQL

  • Ensure you are using the union_dataset_join_clause() macro for queries that employ any
    models using these datasets: deanslist edplan iready overgrad pearson powerschool
    renlearn titan

  • All distinct usage must be accompanied by an comment explaining it's necessity

  • If you are adding a new external source, run:

    dbt run-operation stage_external_sources --vars
"ext_full_refresh: true"

Troubleshooting

@GabyRangelB GabyRangelB requested review from a team as code owners February 20, 2025 22:10
@GabyRangelB
changed test_type to scope
6071e0b
@GabyRangelB
updated grad paths
ebbf5bf
@GabyRangelB
trunk
9290307
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
ce6e50e 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
fixed rpt_college_assessment.... will do qa tomorrow
6cc492b
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
81fc095 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
1182607 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
fixed course_discipline conversion
8508c30
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
91934c9 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
1d21e7b 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
added fake scope so that the PSAT requirement doesnt distinguish betw…
340e338 
…een PSAT10 or PSATNMSQT
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
801dcbf 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
cleaned up score_type for psat
04a5a4f
@GabyRangelB
new njgpa xfer scores view
580ebb5
@GabyRangelB
thinking about new path calcs
762c9e6
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
dfb54ad 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
added rn_undergrad to filter
db39f1c
@GabyRangelB
njgpa scores
1809206
@GabyRangelB
act,sat,psat and rn highest
dbe32d0
@GabyRangelB
hid state_studentnumber_int
c296661
@GabyRangelB
fixed discipline joins
369017e
@GabyRangelB
added cutoff table
7af9e26
@GabyRangelB
rebuilt cutoffs to catch changes
edb90d6
@cbini
Copy link
Member

cbini commented Mar 5, 2025 •
edited
Loading

from #2502

FYI: I added a safecast to stg_collegeboard_psat because the new math test score had a field type conflict. it is currently only showing on my #2470 branch, which I should finish today or tomorrow:
Image

Issue: This error started popping up on Monday afternoon. I have been using this view with no issue on branch #2470 for weeks, so I don't know what changed. The views I'm working on pass build on DBT, but then build doesn't pass on GH. I have to run a full refresh on DBT for the GH to pass, but then a few hours later it fails again.
Image

Thanks!

cbini
cbini requested changes Mar 5, 2025
View reviewed changes
...pptaf/models/powerschool/intermediate/int_powerschool__state_assessments_transfer_scores.sql
Comment on lines +46 to +49
inner join
{{ ref("stg_powerschool__students") }} as n
on s.studentid = n.id
and {{ union_dataset_join_clause(left_alias="s", right_alias="n") }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary: you can join downstream on studentid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need student number there so that the scores CTE in int_students__graduation_path_codes.sql stays simple and works the way i need it to work.

GabyRangelB and others added 19 commits March 5, 2025 19:09
@GabyRangelB
test
ff7a2b9
@GabyRangelB
updated autocomm
1cce5b8
@GabyRangelB
removed comment
b3fa9fd
@GabyRangelB
updated college_assessement_historic
52dbb79
@GabyRangelB
first try at yml documentation
1418958
@GabyRangelB
changed psat total to combined
5c63e8a
@GabyRangelB
ugh ok so no tests yet
1559370
@GabyRangelB
try 2
efbaef2
@GabyRangelB
this thing doesnt even format
a93d576
@GabyRangelB
added description for id
b8ecd84
@GabyRangelB
tried an online tool to see if it works now
0bc2205
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
a05fbe4 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
i was not meant to be a yml coder
8ca91b2
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
c42bbbc 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
removed long comments
165fdcd
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
51cd5d4 
…uick_psat_table_swap_for_grad_requirements
@GabyRangelB
testing a field to be able to dedup, if needed
7b7a820
@GabyRangelB
kinda need discipline
ea1473f
@GabyRangelB
Merge branch 'main' of https://github.com/TEAMSchools/teamster into q…
847eb51 
…uick_psat_table_swap_for_grad_requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbini cbini cbini requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabyRangelB @cbini