Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by passing $lang to schematron extraction #2609

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sydb
Copy link
Member

@sydb sydb commented Oct 29, 2024

The fix for Stylesheets #702 (i.e., PR 704) caused the TEI build to break, because the natural language being processed was not being handed to extract-isosch.xsl, which it now needs to know. This fixes said problem. It passed all tests in Docker on my system.

the lang parameter to extract-isosch.xsl
@ebeshero
Copy link
Member

The repair looks good: I've tested it on my local system, built the Guidelines and exemplars, and ran make validate successfully. I'm going ahead and merging this tonight since it's resolving a release blocker.

Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this after the Stylesheets meeting, but following along. The changes worked locally for me, too, to build the Guidelines.

@ebeshero ebeshero merged commit 06e18c0 into dev Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants