Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nested facsimile elements #2654

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

martinascholger
Copy link
Member

This PR addresses #2565

@martindholmes
Copy link
Contributor

After some discussion with @martinascholger, we decided that this approach is too loose, and allows lots of weird content mixes (facsimiles interleaved with surfaces, for instance) whose meaning is hard to fathom. The feature request is just for the ability to create a facsimile containing child facsimiles, so perhaps the content model should just be an alternate between the existing content model and one or more facsimiles.

@tuurma
Copy link
Contributor

tuurma commented Jan 14, 2025

@martinascholger @martindholmes I agree with the proposed alternate - either nested facsimiles or surfaces etc

@sydb
Copy link
Member

sydb commented Jan 16, 2025

Just to be sure I understand, y’all are proposing

facsimile = ( model.graphicLike | surfaceGrp | surface )+ | facsimile+

as opposed to the current definition (on this ms_2565_facsimile branch) of

facsimile = ( model.graphicLike | surfaceGrp | surface | facsimile )+

Right? If that’s the case, seems like a good idea to me, but I would want to hear from the likes of @MatijaOgrin, @jamescummings, or @schassan before merging into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants