feat!: Claimable trait for all contracts with no coreriff macro #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
reviewed
Feb 5, 2024
willemneal
reviewed
Feb 5, 2024
willemneal
reviewed
Feb 5, 2024
willemneal
requested changes
Feb 5, 2024
There was a problem hiding this comment.
Looks good! Just a couple of notes. One thing that I noticed is that smartdeploy can't initialize itself in one step. So perhaps it's worth creating a new contract that doesn't need an owner and so can't be redeployed. However, it wouldn't have any state. The idea would be to allow deploying contracts with a hash and an init function. This way we can deploy that first doesn't matter the owner, then deploy and initialize smartdeploy.
Possibility to claim/ import a contract to SmartDeploy which hasn't been deployed with the smartdeploy-cli. We keep the notion of ownership and redeployment. Add an admin/ owner to the smartdeploy contract (justfile)
asanson1404
force-pushed
the
feat/claim_contracts
branch
from
51db61a
to
a2f17f7
Compare
willemneal
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Possibility to claim/ import a contract to SmartDeploy which hasn't been deployed with the smartdeploy-cli. We keep the notion of ownership and redeployment.
Add an admin/ owner to the smartdeploy contract (justfile)
Why?
The idea is to easily allow developer to integrate SmartDeploy to their already deployed contract. They also use the function
redeploy_claimed_contractto add the macrosmartdeploy_sdk::core_riff