Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix depth inequality #23

Closed
wants to merge 1 commit into from
Closed

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 30, 2024

@efiring
Copy link
Member

efiring commented Apr 30, 2024

Given that this repo is not used for development, perhaps it is better to let it be a record of the distributed Matlab version (from the official zip file), frozen at whatever points we try to match with C. As we use it, I think that making this Matlab repo diverge from the official versions might make work on the other languages more confusing. That does not restrict us from fixing typos and occasionally diverging in other ways on the C, Rust, Python, R, and Julia sides. But, I'm open to discussion of this strategy issue.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 1, 2024

To be honest I don't know the best approach here. I'm ok closing it and let this PR be just a documentation step for us and others using the Matlab version.

@ocefpaf ocefpaf closed this May 1, 2024
@ocefpaf ocefpaf deleted the infunnel_bug branch May 1, 2024 14:09
@ocefpaf
Copy link
Member Author

ocefpaf commented May 7, 2024

@efiring I was thinking about this and I wonder. We do have the official release in the tags. We can keep latest main in sync with the latest official tag and maintain a branch, community (?), with the bug fixes, typos, etc, that can guide the community on what to do and hopefully get those upstream to the official release. I'm not sure if that is the best idea but many found this repo looking for a way to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants