Update from GSW-C and add declspec for dll export #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm fine with this. Maybe we could merge TEOS-10/GSW-C#69 first and backport the test too? If you think it is too much trouble, let's merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to geoffstanley/neutralocean#15.
Prior to this PR, direct access to the C functions via ctypes worked only on Linux and Mac. This PR makes it work on Windows. A simple test is included. The change is propagated back to GSW-C by TEOS-10/GSW-C#69.
The update from GSW-C also pulls in the new C "infunnel" function which will require significant work to wrap, either by modifying the automated wrapping machinery or by making a one-off wrapper for it. That is left for a subsequent PR.