Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rakki #847

Merged
merged 23 commits into from
Dec 1, 2024
Merged

feat: rakki #847

merged 23 commits into from
Dec 1, 2024

Conversation

n0izn0iz
Copy link
Collaborator

No description provided.

Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz n0izn0iz self-assigned this Dec 31, 2023
Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit c9b6626
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/6590b49c8d692d00082ff77e
😎 Deploy Preview https://deploy-preview-847--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit e673393
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/674bc03200214d0008356821
😎 Deploy Preview https://deploy-preview-847--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Norman Meier <[email protected]>
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit e673393
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/674bc032bd4b220008916387
😎 Deploy Preview https://deploy-preview-847--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou
Copy link
Collaborator

WaDadidou commented Nov 29, 2024

The user can see the tickets in the Prize Pot image and the Remaining tickets image
We should display the user's bought tickets amount, no ? (So, modify the contract)

I don't want to break my review, and I won't push before getting your advise, but I purpose this:

#[msg(query)]
fn tickets_count_by_user(&self, ctx: QueryCtx, user_addr: String) -> StdResult<u16> {
    let user_addr = ctx.deps.api.addr_validate(&user_addr)?;
    let mut count = 0;

    for r in
        self.current_tickets
            .range(ctx.deps.storage, None, None, cosmwasm_std::Order::Ascending)
    {
        let (_, addr) = r?;
        if addr == user_addr {
            count += 1;
        }
    }

    Ok(count)
}

@WaDadidou
Copy link
Collaborator

WaDadidou commented Nov 29, 2024

I don't want to break my review, and I won't push before getting your advise. Should we make these modifs in this PR ?

Missing UX stuff

There is no feedback if the user is not connected.
Maybe we could add a Connect Wallet button instead of showing empty balance, on the Buy modal

image

Missing design stuff (Yes, it's a "rushed" version, but could we fix these now ?)

Missing the yellow background

image

Missing the ticket icon

image

Wrong image
image
Because it's the "rushed version" design.
The "improved v1" design has this image
image

.eslintrc.js Outdated Show resolved Hide resolved
packages/components/boxes/Box.tsx Outdated Show resolved Hide resolved
packages/components/gradientText/GradientText.tsx Outdated Show resolved Hide resolved
packages/components/gradientText/GradientText.tsx Outdated Show resolved Hide resolved
packages/components/gradientText/GradientText.web.tsx Outdated Show resolved Hide resolved
packages/screens/Rakki/RakkiScreen.tsx Outdated Show resolved Hide resolved
packages/screens/Rakki/RakkiScreen.tsx Show resolved Hide resolved
packages/screens/Rakki/RakkiScreen.tsx Show resolved Hide resolved
rust/cw-contracts/rakki/src/contract.rs Show resolved Hide resolved
packages/scripts/storeContract.ts Outdated Show resolved Hide resolved
@n0izn0iz
Copy link
Collaborator Author

I added the tickets_count_by_user query in 74acd12

For the ui/ux overhaul, I'll let you do it in another PR

@n0izn0iz n0izn0iz marked this pull request as ready for review November 30, 2024 09:48
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
@WaDadidou WaDadidou self-requested a review December 1, 2024 01:51
@n0izn0iz n0izn0iz merged commit b9a393a into main Dec 1, 2024
23 checks passed
@n0izn0iz n0izn0iz deleted the rakki branch December 1, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants