-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3주차] 이 상 형 월 드 컵 #7
base: main
Are you sure you want to change the base?
Changes from all commits
9a20eef
d8b729a
08e53fb
bbcde4f
3464d1b
3033a36
e0d5f02
94e151f
bde994f
5586fab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
||
# dependencies | ||
/node_modules | ||
/.pnp | ||
.pnp.js | ||
|
||
# testing | ||
/coverage | ||
|
||
# production | ||
/build | ||
|
||
# misc | ||
.DS_Store | ||
.env.local | ||
.env.development.local | ||
.env.test.local | ||
.env.production.local | ||
|
||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# Getting Started with Create React App | ||
|
||
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
|
||
## Available Scripts | ||
|
||
In the project directory, you can run: | ||
|
||
### `yarn start` | ||
|
||
Runs the app in the development mode.\ | ||
Open [http://localhost:3000](http://localhost:3000) to view it in your browser. | ||
|
||
The page will reload when you make changes.\ | ||
You may also see any lint errors in the console. | ||
|
||
### `yarn test` | ||
|
||
Launches the test runner in the interactive watch mode.\ | ||
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
|
||
### `yarn build` | ||
|
||
Builds the app for production to the `build` folder.\ | ||
It correctly bundles React in production mode and optimizes the build for the best performance. | ||
|
||
The build is minified and the filenames include the hashes.\ | ||
Your app is ready to be deployed! | ||
|
||
See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
|
||
### `yarn eject` | ||
|
||
**Note: this is a one-way operation. Once you `eject`, you can't go back!** | ||
|
||
If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
||
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own. | ||
|
||
You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it. | ||
|
||
## Learn More | ||
|
||
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
||
To learn React, check out the [React documentation](https://reactjs.org/). | ||
|
||
### Code Splitting | ||
|
||
This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting) | ||
|
||
### Analyzing the Bundle Size | ||
|
||
This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size) | ||
|
||
### Making a Progressive Web App | ||
|
||
This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app) | ||
|
||
### Advanced Configuration | ||
|
||
This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration) | ||
|
||
### Deployment | ||
|
||
This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment) | ||
|
||
### `yarn build` fails to minify | ||
|
||
This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"name": "week3-worldcup", | ||
"version": "0.1.0", | ||
"private": true, | ||
"dependencies": { | ||
"@testing-library/jest-dom": "^5.14.1", | ||
"@testing-library/react": "^13.0.0", | ||
"@testing-library/user-event": "^13.2.1", | ||
"react": "^18.1.0", | ||
"react-dom": "^18.1.0", | ||
"react-scripts": "5.0.1", | ||
"styled-components": "^5.3.5", | ||
"web-vitals": "^2.1.0" | ||
}, | ||
"scripts": { | ||
"start": "react-scripts start", | ||
"build": "react-scripts build", | ||
"test": "react-scripts test", | ||
"eject": "react-scripts eject" | ||
}, | ||
"eslintConfig": { | ||
"extends": [ | ||
"react-app", | ||
"react-app/jest" | ||
] | ||
}, | ||
"browserslist": { | ||
"production": [ | ||
">0.2%", | ||
"not dead", | ||
"not op_mini all" | ||
], | ||
"development": [ | ||
"last 1 chrome version", | ||
"last 1 firefox version", | ||
"last 1 safari version" | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
<meta name="theme-color" content="#000000" /> | ||
<meta | ||
name="description" | ||
content="Web site created using create-react-app" | ||
/> | ||
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" /> | ||
<!-- | ||
manifest.json provides metadata used when your web app is installed on a | ||
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/ | ||
--> | ||
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | ||
<!-- | ||
Notice the use of %PUBLIC_URL% in the tags above. | ||
It will be replaced with the URL of the `public` folder during the build. | ||
Only files inside the `public` folder can be referenced from the HTML. | ||
Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will | ||
work correctly both with client-side routing and a non-root public URL. | ||
Learn how to configure a non-root public URL by running `npm run build`. | ||
--> | ||
<title>React App</title> | ||
</head> | ||
<body> | ||
<noscript>You need to enable JavaScript to run this app.</noscript> | ||
<div id="root"></div> | ||
<!-- | ||
This HTML file is a template. | ||
If you open it directly in the browser, you will see an empty page. | ||
You can add webfonts, meta tags, or analytics to this file. | ||
The build step will place the bundled scripts into the <body> tag. | ||
To begin the development, run `npm start` or `yarn start`. | ||
To create a production bundle, use `npm run build` or `yarn build`. | ||
--> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"short_name": "React App", | ||
"name": "Create React App Sample", | ||
"icons": [ | ||
{ | ||
"src": "favicon.ico", | ||
"sizes": "64x64 32x32 24x24 16x16", | ||
"type": "image/x-icon" | ||
}, | ||
{ | ||
"src": "logo192.png", | ||
"type": "image/png", | ||
"sizes": "192x192" | ||
}, | ||
{ | ||
"src": "logo512.png", | ||
"type": "image/png", | ||
"sizes": "512x512" | ||
} | ||
], | ||
"start_url": ".", | ||
"display": "standalone", | ||
"theme_color": "#000000", | ||
"background_color": "#ffffff" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# https://www.robotstxt.org/robotstxt.html | ||
User-agent: * | ||
Disallow: |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import React from "react"; | ||
import { createGlobalStyle } from 'styled-components'; | ||
import Game from './components/Game/Game'; | ||
|
||
const GlobalStyle = createGlobalStyle` | ||
* { | ||
margin: 0, | ||
padding: 0, | ||
box-sizing: border-box; | ||
} | ||
`; | ||
|
||
function App() { | ||
return ( | ||
<> | ||
<GlobalStyle></GlobalStyle> | ||
<Game /> | ||
</> | ||
); | ||
} | ||
|
||
export default App; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import React, { useState, useEffect } from "react"; | ||
import { FlexBox } from './Style'; | ||
import vs from '../../Img/vs.png'; | ||
import crown from '../../Img/crown.png'; | ||
|
||
const items = [ | ||
{ | ||
name: "황민현", | ||
src: require("../../Img/민현.jpeg") | ||
}, | ||
{ | ||
name: "안효섭", | ||
src: require("../../Img/효섭.jpeg") | ||
}, | ||
{ | ||
name: "이주연", | ||
src: require("../../Img/주연.jpeg") | ||
}, | ||
{ | ||
name: "정진영", | ||
src: require("../../Img/진영.jpeg") | ||
}, | ||
]; | ||
Comment on lines
+6
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기에 적어줘도 문제는 없지만 파일을 따로 빼서 import를 하면 더 깔끔할 것 같습니다! |
||
|
||
const Game = () => { | ||
const [handsomes, setHansomes] = useState([]); | ||
const [displays, setDisplays] = useState([]); | ||
const [winners, setWinners] = useState([]); | ||
|
||
useEffect(() => { | ||
items.sort(() => Math.random() - 0.5); // item 값 랜덤하게 설정해주고자 함 | ||
setHansomes(items); | ||
setDisplays([items[0], items[1]]); | ||
}, []); | ||
Comment on lines
+30
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 크으 useEffect 잘 쓴다.. 역시 똑똑이 |
||
|
||
const clickHandler = handsome => (event) => { // handsome 객체가 들어갔을 때 반환되는 이벤트를 다시 parameter로 받아서 반환해야하기 때문에 감쌈 | ||
if (handsomes.length <= 2) { | ||
if (winners.length === 0) { // 결승전 | ||
setDisplays([handsome]); | ||
} else { | ||
let updatedHandsome = [...winners, handsome]; | ||
setHansomes(updatedHandsome); | ||
setDisplays([updatedHandsome[0], updatedHandsome[1]]); | ||
setWinners([]); | ||
} | ||
} else if (handsomes.length > 2) { // 남은 핸썸가이가 두명 이상이면 계속해서 이상형 월드컵 진행 | ||
setWinners([...winners, handsome]) | ||
setDisplays([handsomes[2], handsomes[3]]) | ||
setHansomes(handsomes.slice(2)) // 현재 노출된 2개 제외 | ||
} | ||
}; | ||
|
||
return ( | ||
<FlexBox> | ||
<h1 className="title">이 상 형 월 드 컵</h1> | ||
{displays.map(item => { // map을 사용할 때는 key 값을 반드시 설정해줘야함! | ||
return ( | ||
<div className="flex-1" key={item.name} onClick={clickHandler(item)}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. onClick={ ()=>clickHandler(item) } |
||
<img className="handsome-img" src={item.src} alt="handsome" /> | ||
|
||
<div className="name">{item.name}</div> | ||
Comment on lines
+55
to
+61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 제가 알기로 styled-components의 가장 큰 장점 중 하나가 기존의 className을 사용하지 않는 것이라고 알고 있어요! styled-components를 조금 더 활용해보는 것은 어떨까요? |
||
</div> | ||
); | ||
})} | ||
{/* { winners.length === 0 ? | ||
<img className="vs-img" src={vs} alt="vs" /> | ||
: null | ||
} */} | ||
</FlexBox> | ||
); | ||
}; | ||
|
||
export default Game; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import styled from "styled-components"; | ||
|
||
export const FlexBox = styled.div` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저도 처음에는 style.js라는 파일을 만들어서 styled-components 들을 모아놨는데 styled-components의 장점이 스타일링을 바로 그 코드파일 에서 할 수 있는 점이라고 하더라고요. 중복되는 코드는 css로 빼고 세부적인 스타일링이나 한 두번 사용되는 스타일링은 styled-components를 사용해서 해당 파일에 적는다고 윤선이가 알려줬습니다. 어디까지나 개인 취향이긴 하지만 장점을 살려보는 것도 좋을 것 같습니다! |
||
display: flex; | ||
flex-wrap: wrap; | ||
height: 100vh; | ||
|
||
.title { | ||
position: absolute; | ||
z-index: 2; | ||
top: 0; | ||
left: 50%; | ||
transform: translateX(-50%); | ||
background-color: #fff; | ||
padding: 0px 30px; | ||
text-transform: uppercase; | ||
padding-bottom: 10px; | ||
} | ||
|
||
.flex-1 { | ||
flex: 1; | ||
min-width: 500px; | ||
overflow: hidden; | ||
background-color: black; | ||
position: relative; | ||
} | ||
|
||
.handsome-img { | ||
width: 100%; | ||
height: 100%; | ||
transition: 0.5s; | ||
cursor: pointer; | ||
} | ||
|
||
.handsome-img: hover { | ||
transform: scale(1.1); | ||
opacity: 0.8; | ||
} | ||
|
||
.vs-img { | ||
position: absolute; | ||
left: 50%; | ||
transform: translateX(-50%); | ||
padding: 0px 30px; | ||
padding-bottom: 10px; | ||
} | ||
|
||
.name { | ||
position: absolute; | ||
z-index: 3; | ||
color: #fff; | ||
bottom: 10%; | ||
font-size: 90px; | ||
left: 50%; | ||
transform: translateX(-50%); | ||
} | ||
`; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import React from 'react'; | ||
import ReactDOM from 'react-dom/client'; | ||
import App from './App'; | ||
|
||
const root = ReactDOM.createRoot(document.getElementById('root')); | ||
root.render( | ||
<React.StrictMode> | ||
<App /> | ||
</React.StrictMode> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전역 스타일링 사용 베리 굳~!
reset css 사용해서 브라우저마다 적용되어 있는 기본 스타일도 초기화 시켜주면 스타일링할 때 더 편할 것 같습니다!