Add a JSR-199 based compiler #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a JSR-199 based compiler, see #203. It implements in-memory compilation without the need for writing temporary files.
Limitations, it currently does not support loading classes from the TCCL, instead it uses the
classpathparameter if set. I am not sure loading from the TCCL could be implemented.JavaFileManager#getClassLoaderseems to be used only for annotation processors.JavaFileManager#getFileForInputseems to be used only for loading the source files. InsteadJavaFileManager#listseems to be used for loading classes. Unfortunately we can not introspect a genericClassLoader.It currently lacks any tests, I would appreciate any guidance on what tests would be appropriate and any examples that you have.
I tried to follow the formatting conventions of other classes but couldn't find any documentation or settings.