Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add --refresh flag to dm_qc_report #367

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Conversation

DESm1th
Copy link
Contributor

@DESm1th DESm1th commented Nov 12, 2024

This PR fixes:

  • A dm_qc_report.py doc string error telling users to load MATLAB instead of our actual module matlab (76634df)
  • A function name typo that caused crashes when running dm_qc_report.py with the --remake flag (5a7d378)
  • A recurring issue with dm_qc_report.py queue jobs timing out for very large scans (59f882c)
  • A bug that stopped regeneration of existing QC files when running dm_qc_report.py with the --remake flag (3f6a409, bfadd08)

This PR adds:

  • A --refresh flag so that header differences (and scan lengths) can be forced to be recalculated without having to delete existing files or waiting for all metrics to regenerate. This is useful when the IgnoreHeaderFields or HeaderFieldTolerance settings are updated in the config files and differences need to be cleared out in response. (dae19f5)

@DESm1th DESm1th requested a review from a team as a code owner November 12, 2024 23:22
@github-actions github-actions bot added the feature Tagged PR addes a new feature label Nov 12, 2024
@DESm1th DESm1th merged commit 62269de into TIGRLab:main Nov 12, 2024
3 of 5 checks passed
@DESm1th DESm1th deleted the header_diffs branch November 12, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Tagged PR addes a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant