Resolve log appender conflict when resuming an ingest #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"prudent" probably not helpful as we don't have multiple jvms, might even slow things down
menzowindhouwer
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
prudent doe come potentially with a time penalty: https://logback.qos.ch/manual/appenders.html#prudent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the error about the DEVEL and USER file appenders already existing in a resumed run. appender.stop() doesn't actually seem to get rid of them completely, so the number of file appenders (and thereby open files) grows over time, but that was already the case.