-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify process of making releases #582
Conversation
TODO: Fix upload of JARs to release, it currently cannot find the right files |
Thanks @Sophietje! This change is very helpful and allows us to release new versions more often 👍 Some general remarks:
I've finished my review and added some comments here and there. Nothing blocking, so I think we are ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing 👍
I think for now this is the best approach. By the way, GitLab has a similar approach to defining workflows nowadays (https://docs.gitlab.com/ee/ci/quick_start/).
I think releasing 1.3.0 is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're ready to go!
This PR adds a Github workflow for (1) drafting a release, and (2) uploading Docker images to the registry.
This will modify the way that we're currently making releases. I envision the following workflow:
Fixes #490