refactor(theme): ๐กRemove sizes.ts and fix text-styles.ts #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
AlgoRoots
force-pushed
the
feat/container
branch
from
1221e36 to
b5d92f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ํ์ฌ ๋ณด์ผ๋ฌํ๋ ์ดํธ์ theme > foundations > sizes.ts ํ์ผ์ ์ฐจํฌ๋ผ ์ปจํ ์ด๋์ maxW๊ฐ์ ์ ์ํ๊ธฐ ์ํด ์์ฑ๋์์ต๋๋ค.
๊ทธ๋ฐ๋ฐ theme > components > single > container.ts์์ container ์ปดํฌ๋ํธ์ maxW๋ฅผ ์ ์ํ๊ณ ์์ด์ ๋ถํ์ํ ํ์ผ์ด๋ผ๊ณ ์๊ฐํฉ๋๋ค.
๋ฌผ๋ก sizes.ts์ ์ญํ ์ด containers์ maxW๋ง ์ ์ํ๋ ๊ฒ์ ์๋๊ธฐ ๋๋ฌธ์ ์ ์งํ๋ ๊ฒ์ ์๊ฐํ์ผ๋, ํ๋ก์ ํธ ๊ฒฝํ์ ๊ฑฐ์ ์ฌ์ฉํ์ง ์๋ ํ์ผ์ด๋ผ๊ณ ์๊ฐ๋์ด ์ญ์ ํ์ต๋๋ค.
๋ณด์ผ๋ฌํ๋ ์ดํธ๋ ํ์ฌ pretendardํฐํธ๋ฅผ ๊ธฐ์ค์ผ๋ก ๋์์ด๋๊ฐ ์ก์๋ typograghy ์์คํ ์ text-styles์ ์ ์ฉํ๊ณ ์์ต๋๋ค. ์์คํ ์ ์ฉ์ ํท๊ฐ๋ฆฌ์ง ์๋๋ก ์ฌ๋ฌ ํฐํธ๊ฐ ์ฌ์ฉ๋ ๊ฒฝ์ฐ๋ฅผ ๋๋นํด์ font๋ณ๋ก textStyles ๊ฐ์ฒด๋ฅผ ๋ถ๋ฆฌํ์ต๋๋ค.