Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installation] fix installation and some name typo #146

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

TheaperDeng
Copy link
Collaborator

@TheaperDeng TheaperDeng commented Oct 17, 2024

Description

1. Motivation and Context

  1. Change the installation option from [all] to [fast_jl] since it's the only optional package among the dependencies.
  2. Rename an example filename to better reflect the content
  3. Fix the LDS groundtruth calculation by flipping the result to make it consistent with the score calculated by attributors.

2. Summary of the change

See motivation

3. What tests have been added/updated for the change?

  • Unit test: Typically, this should be included if you implemented a new function/fixed a bug.

Copy link
Contributor

@jiaqima jiaqima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

README.md Outdated
@@ -26,20 +26,20 @@ git clone https://github.com/TRAIS-Lab/dattri
pip install -e .
```

If you want to use all features on CUDA and accelerate the library, you may install the full version by
If you want to use `fast_jl` to accelerate the random projection, you may install the full version by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the full version" -> "the version with fast_jl"

@@ -160,7 +160,8 @@ def target_func(ckpt_path, dataloader):
target function calculated on all test samples under `num_subsets` models,
each retrained on a subset of the training data. The second tensor has the
shape (num_subsets, subset_size), where each row refers to the indices of
the training samples used to retrain the model.
the training samples used to retrain the model. The targeted value will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targeted -> target

@TheaperDeng TheaperDeng merged commit 867c992 into TRAIS-Lab:main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants