More PRESS support and signal processing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract fids, simple averaging, and spectrum to support PRESS * HSVD water suppression to work with AxisArray and added test * Minor: add downsample keyword arg to spectrum function
darrencl
force-pushed
the
more-press-processing
branch
from
60dfee6 to
8fba1f5
Compare
darrencl
changed the title
darrencl
changed the title
|
@c42f I am also adding the phase correction, which is inspired by suspect.py |
darrencl
force-pushed
the
more-press-processing
branch
from
3fa57f6 to
62129d3
Compare
darrencl
force-pushed
the
more-press-processing
branch
3 times, most recently
from
33e793a to
f0f49bf
Compare
|
Hey @c42f , I am pretty much done with this PR, could you take a quick look to check if what I added makes sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Press support:
Signal processing:
Minor: add downsample keyword arg to spectrum function
Closes #3