-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starr): Update of the French Guide #2087
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one fails to render correctly (same with the Sonarr one!)
The main reason because it fails is because:
The french-vostfr CF JSON doesn't have a vostfr
scoring but uses french-vostfr
"trash_scores": {
"anime-radarr": -10000,
"french-vostfr": 1000
},
There is no default scoring set so nothing to show and that's why it fails with MULTi.VF
and MULTi.VO
Also, I noticed that you sometimes use: french-vostfr
for scoring and the other time vostfr
, perhaps we could consider for consistency to use for the French guide/scoring that everything starts with "french-xxx"
?
I'll create a discord chat where we can discuss this, it's a bit easier for me to respond when I'm not at home
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I tried to put everything under french-xxx
but missed some apparently will check and update those.
Co-authored-by: TRaSH <[email protected]>
Pull Request
Purpose
Updating the French Guide to include improvement from latest Radarr/Sonarr changes, to improve upon specific settings, and streamline some approach.
Open Questions and Pre-Merge TODOs
Requirements