Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starr): Update of the French Guide #2087

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

NiceTSY
Copy link
Contributor

@NiceTSY NiceTSY commented Oct 8, 2024

Pull Request

Purpose

Updating the French Guide to include improvement from latest Radarr/Sonarr changes, to improve upon specific settings, and streamline some approach.

Open Questions and Pre-Merge TODOs

  • Implement new Language CFs to align with the rest of the guide language recommendation
  • Update the Radarr French Guide
  • Update the Sonarr French Guide
  • Update some French CFs
  • (Maybe) Update the Sonarr French Anime Guide
  • Check language errors again
  • Check technical errors again
  • Check scoring a last time

Requirements

@NiceTSY NiceTSY added Type: Enhancement Feature Request or Improvement of suboptimal status quo Status: In Progress Work in progress Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Area: French Relating to the French Guide labels Oct 8, 2024
@NiceTSY NiceTSY self-assigned this Oct 8, 2024
@github-actions github-actions bot added Area: Backend Backend Changes, not related to a specific section and removed Area: Sonarr Sonarr Related labels Oct 8, 2024
@github-actions github-actions bot added the Area: Sonarr Sonarr Related label Oct 8, 2024
@NiceTSY NiceTSY marked this pull request as ready for review October 13, 2024 14:58
@NiceTSY NiceTSY requested a review from a team October 13, 2024 14:58
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Oct 14, 2024
@github-actions github-actions bot removed the Status: Conflicted Pull Request is Conflicted label Oct 15, 2024
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Nov 1, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one fails to render correctly (same with the Sonarr one!)
image

The main reason because it fails is because:

The french-vostfr CF JSON doesn't have a vostfr scoring but uses french-vostfr

  "trash_scores": {
    "anime-radarr": -10000,
    "french-vostfr": 1000
  },

There is no default scoring set so nothing to show and that's why it fails with MULTi.VF and MULTi.VO

Also, I noticed that you sometimes use: french-vostfr for scoring and the other time vostfr, perhaps we could consider for consistency to use for the French guide/scoring that everything starts with "french-xxx"?

I'll create a discord chat where we can discuss this, it's a bit easier for me to respond when I'm not at home

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I tried to put everything under french-xxx but missed some apparently will check and update those.

includes/french-guide/french-guide-language-profiles-en.md Outdated Show resolved Hide resolved
includes/french-guide/french-guide-language-profiles-en.md Outdated Show resolved Hide resolved
includes/french-guide/french-guide-language-profiles-en.md Outdated Show resolved Hide resolved
includes/french-guide/french-guide-language-profiles-fr.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: French Relating to the French Guide Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Status: Conflicted Pull Request is Conflicted Status: In Progress Work in progress Type: Enhancement Feature Request or Improvement of suboptimal status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] (Starr French): add CAN to the VFQ CF for Canadian audio language
2 participants