Manually merged release-0.4.1 branch and 27-new-caching-solution. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meffmadd
reviewed
May 6, 2024
package.json
Outdated
| @@ -73,7 +73,8 @@ | |||
| "@mui/material": "^5.13.4", | |||
| "@mui/system": "^5.13.2", | |||
| "@mui/x-date-pickers": "^6.19.0", | |||
| "@tanstack/react-query": "^5.20.5", | |||
| "@tanstack/react-query": "^5.27.5", | |||
| "@tanstack/react-query-devtools": "^5.27.8", | |||
There was a problem hiding this comment.
react-query-devtools sounds more like a dev dependency
meffmadd
reviewed
May 6, 2024
| id="alert-dialog-description" | ||
| sx={{ fontSize: 10, fontFamily: "'Roboto Mono', monospace" }} | ||
| > | ||
| {logs} |
There was a problem hiding this comment.
Could be rewritten as {logs || "No logs available"} to omit the second Typography element
meffmadd
requested changes
May 6, 2024
There was a problem hiding this comment.
The implementation looks very clean!
2 points:
- I don't think caching is configured correctly. The reason we wanted to switch to Tanstack Query is to have client-side caching. When I go to the coursemanage view, click on a lecture, go back, click on the same lecture again, etc., there are always requests made through the request service. I think the
staleTimehas to be set to be>0? - We can then remove the current HTTP browser-based caching by removing the
@cachedecorator from the tornado handler functions.
florian-jaeger
requested changes
May 7, 2024
There was a problem hiding this comment.
Good job! I experienced the redundant data fetching as well that @meffmadd pointed out.
… Omitted unnecessary Typography element in edit-submission.tsx. #27
Added react Dev Tools to Dev dependencise for debugging purposes, will be deleted from components later. To Do: FileLists send requests for each file that is shown, which shouldnt be the case -> to fix.
…check file remote status of each file in the directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
27-react-query-cachingcontains all changes from 27-new-caching-solution. I had to manually merge my old branch withrelease-0.4.1due to modifications in file selection for pushing, not present in the original27-new-caching-solutionbranch, leading to many conflicts. In the27-react-query-cachingchanges fromrelease-0.4.1and27-new-caching-solutionare integrated.Ref: #27