Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 3km grid with tile name in metres (not km) #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

philipjales
Copy link

The time names are shortened to display '3' km instead of '3000'm.
Added a parameter to allow selection of which naming scheme to use.

@bbauerma
Copy link
Collaborator

Hi there @philipjales ! Thanks for the contribution - a quick question: How urgent is this for you to have it merged (one test is not running through)?

We're working on a major update of the package, giving full flexibility on the grid samplings and tile sizes. This will accommodate your use case of 3000m sampling.

@philipjales
Copy link
Author

Hi @bbauerma

The intention with this branch is to allow tiling with tile sampling of 3000m, but with"3000" in the tile name rather than "3K". We are using Equi7 grids but standardised on that convention to the tile filenames.

Thanks for getting back to me on this one. I'm happy for this change to sit an gather dust. I rather made the change and was trying to push to my fork, but make a pull-request by mistake.

We appreciate the efforts in making this project available and the upkeep to turn it into a more widely used library.

@bbauerma
Copy link
Collaborator

hi @philipjales. We're aiming for a most flexible setup for the sampling and tilings. Do you have need for other tile sizes and pixel samplings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants