Anomalizer #14

pstradio · 2022-04-14T13:13:13Z

Functions to combine a Thematic CDR (for climatology) and a Interim CDR (for operative data) to apply anomalies/percentiles or custom functions and generate stacks with results ready to be plotted

Merge develop

Update documentation, fix CI

* Update sphinx documentation * Update .coveragerc * Update test-requirements.txt

added MIT License

* Update sphinx documentation * Update .coveragerc * Update test-requirements.txt * Change cell grid image * Update .gitmodules * Add new submodule * Change test data path * Change url to http

* Update sphinx documentation * Update .coveragerc * Update test-requirements.txt * Change cell grid image * Update .gitmodules * Add new submodule * Change test data path * Change url to http * Add pyyaml * Add empty .coveralls.yml * Add pytest-cov * add coveralls.yml without token * Add gitattributes older pytest version * Change travis installation scheme * Fix typo * Update .gitattributes * Update .travis.yml

Fix docs requirements file name

Update reader, support new versions, restructure

pstradio · 2022-04-14T13:19:42Z

Re-added xrcube.py script - why was it removed in the first place? Need to adapt code

wpreimes

This package needs a major overhaul anyway, so I'm not too picky about the updates, but lets still try to keep it clean for the most part ;)

wpreimes · 2022-04-14T13:14:45Z

src/c3s_sm/anomalizer.py

+    )
+
+
+if __name__ == '__main__':


please delete if __name__ ...

Either move to test or to docs if we should keep it

wpreimes · 2022-04-14T13:15:42Z

src/c3s_sm/anomalizer.py

+        end of the considered period. Format: 'YYYY-mm-dd'
+        **Note**: defines size of the netCDF stack
+
+    Attributes


Remove or fill out

wpreimes · 2022-04-14T13:17:05Z

src/c3s_sm/anomalizer.py

+        # apply the function which uses the icdr and tcdr
+        out = funct(icdr_ts, tcdr_ts, **fun_kwargs)
+
+        assert type(out) == pd.Series, "The given function should return a Series"


generally AssertionErrors should only be raised in Tests

wpreimes · 2022-04-14T13:17:46Z

src/c3s_sm/anomalizer.py

+        if grid_subset is None:
+            grid_subset = self.grid
+
+        print(


remove print statement or replace with log function

wpreimes · 2022-04-14T13:18:38Z

src/c3s_sm/anomalizer.py

+    """
+
+    def __init__(self, *args, **kwargs):
+        self._fillvalue_in = -777777.


is it possible to omit this, or can be make this more dynamic?

wpreimes · 2022-04-14T13:19:11Z

src/c3s_sm/anomalizer.py

+            cellds = self.read_cell(cell, **kwargs)
+            ds.append(cellds)
+
+        print("Combining cell datasets in a global cube")


print -> log

wpreimes · 2022-04-14T13:20:40Z

src/c3s_sm/xrcube.py

@@ -12,36 +12,42 @@
 import pandas as pd
 import os

-from c3s_sm.interface import fntempl
+from interface import fntempl


sure that this works?

wpreimes · 2022-04-14T13:21:07Z

src/c3s_sm/interface.py

@@ -592,14 +596,14 @@ def iter_ts(self, **kwargs):
    def write_ts(self, *args, **kwargs):
        pass

+
 if __name__ == '__main__':


wpreimes · 2022-04-14T13:21:23Z

src/c3s_sm/xrcube.py

@@ -217,24 +229,24 @@ def read_ts(self,
    def write_stack(self, out_file, **kwargs):
        vars = [v for v in list(self.ds.variables.keys()) if v not in self.ds.coords.keys()]

-        encoding = {v : {'zlib': True, 'complevel': 6} for v in vars}
+        encoding = {v: {'zlib': True, 'complevel': 6} for v in vars}

        with ProgressBar():
            self.ds.to_netcdf(out_file, encoding=encoding, **kwargs)


 if __name__ == '__main__':


wpreimes · 2022-04-14T13:22:57Z

Re-added xrcube.py script - why was it removed in the first place? Need to adapt code

I think that comes from another branch

wpreimes and others added 30 commits October 19, 2018 18:34

Add basic documentation

97d8e43

Update changes

b27c9ab

Add parse for file name parsing

76540cc

Reshuffle without passed parameters, update test

c3a5d73

Fix typo

0d6753c

Fix import statements

ca95244

Merge branch 'develop' of github.com:wpreimes/c3s_sm into develop

063f917

Fix python 3 issue with dict keys not a list

6c97837

Test with python 3.6 instead of 3.4

cd84caf

Update .travis.yml

092893d

Update test-requirements.txt

f5ca6f1

Merge pull request TUW-GEO#1 from wpreimes/develop

c8e2ab9

Merge develop

Update setup and requirements

f5d66e2

Merge pull request TUW-GEO#1 from wpreimes/master

240cbbe

Update documentation, fix CI

Docu and CI update (TUW-GEO#2)

44cc7e6

* Update sphinx documentation * Update .coveragerc * Update test-requirements.txt

Update LICENSE.txt

1bde75b

added MIT License

removal of latex docs, manual and textinfo docs

b47bf74

removal of unicode text in conf.py

995d139

removed python 3 requirement from readthedocs.yml

0540490

deleted doc_requirements and readthedocs.yml

85cc3af

updated so same as esa_cci_sm docs makefile (build working)

8a94700

Update path to submodule

29a72ea

Fix docu and change submodule path (TUW-GEO#3)

f2d46d5

* Update sphinx documentation * Update .coveragerc * Update test-requirements.txt * Change cell grid image * Update .gitmodules * Add new submodule * Change test data path * Change url to http

Update requirements (TUW-GEO#5)

5e20167

Implement smecv-grid (TUW-GEO#6)

1100c22

Update README.rst

e1fa531

Fix docs requirements file name

f9da1a1

Merge pull request TUW-GEO#7 from wpreimes/develop

16cd0a3

Fix docs requirements file name

Update varnames.rst

d4f6e6d

wpreimes and others added 23 commits December 14, 2020 21:24

Add v201912

6eb2600

Fill with NaN

d4f1292

Revert

93e881a

Update to combine icdr and cdr

a279fa6

Add datacube class

d7a6c26

Update data cube reading

852b49f

Update image reading

b3772ef

Update subset reading

073f646

Update image reader and tests

474af01

Fix reshuffle and tests

75bc036

Update reshuffle and docs

5142594

Update readers, tests and package structure

1211cf3

Add workflows

1f54133

Rename folder

d46327b

Update ci and environemnt

0d2a0ff

Update changelog

785f360

remove xarray datacube class for now

4e5d969

Update testdata module

3ea40c1

Fix testdata pointer

f231e60

Sort files

85d051c

Merge pull request TUW-GEO#13 from wpreimes/master

83b8c83

Update reader, support new versions, restructure

Anomaly calculation and repurposing for C3S

6f0c11a

improved documentation

b646a1d

pstradio requested a review from wpreimes April 14, 2022 13:13

pstradio marked this pull request as draft April 14, 2022 13:13

solved conflicts

aba7637

wpreimes requested changes Apr 14, 2022

View reviewed changes

wpreimes force-pushed the master branch from 2ab9366 to 5857214 Compare August 29, 2024 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Anomalizer #14

Anomalizer #14

pstradio commented Apr 14, 2022

pstradio commented Apr 14, 2022

wpreimes left a comment

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes Apr 14, 2022

wpreimes commented Apr 14, 2022

Anomalizer #14

Are you sure you want to change the base?

Anomalizer #14

Conversation

pstradio commented Apr 14, 2022

pstradio commented Apr 14, 2022

wpreimes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wpreimes commented Apr 14, 2022