ulon, ulat #56
Closed
ulon, ulat #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unique lon/lat values
cpaulik
reviewed
Sep 4, 2018
| @@ -170,6 +170,9 @@ def __init__(self, lon, lat, gpis=None, geodatum='WGS84', subset=None, | |||
| self.arrlon = lon | |||
| self.arrlat = lat | |||
|
|
|||
| self.ulon = np.unique(lon) | |||
There was a problem hiding this comment.
If we add that then please document in the attributes above.
|
As discussed we will not add this due to the easy confusion it adds if the lat, lon are sorted and data values are not. If somebody needs the unique lat and lon values then they are easy to compute from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ulonandulatto basegrid which can be used for other functions to get the unique lon/lat values.Required for TUW-GEO/pynetcf#47