Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Switch to confvals for mod.web_layout #455

Merged
merged 4 commits into from
Apr 15, 2024
Merged

[TASK] Switch to confvals for mod.web_layout #455

merged 4 commits into from
Apr 15, 2024

Conversation

linawolf
Copy link
Member

@linawolf linawolf commented Apr 13, 2024

  • use confvals
  • correct indentation
  • correct header levels
  • Give headers to examples

No other text changes made.

The page did not yet exist in 11.5

releases: main, 12.4

* use confvals
* correct indentation
* correct header levels
* Give headers to examples

No other text changes made

releases: main, 12.4, 11.5
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page exists, but in "mod" directly and not as a separate file. Was changed recently.

Documentation/PageTsconfig/Mod/WebLayout.rst Outdated Show resolved Hide resolved
Documentation/PageTsconfig/Mod/WebLayout.rst Outdated Show resolved Hide resolved
@linawolf
Copy link
Member Author

The changes would then have to be backported manually if we really want to put in the work

* use confvals
* correct indentation
* correct header levels
* Give headers to examples

No other text changes made

releases: main, 12.4, 11.5
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation/PageTsconfig/Mod/WebLayout.rst Outdated Show resolved Hide resolved
Documentation/PageTsconfig/Mod/WebLayout.rst Outdated Show resolved Hide resolved
Documentation/PageTsconfig/Mod/WebLayout.rst Outdated Show resolved Hide resolved
Documentation/PageTsconfig/Mod/WebLayout.rst Outdated Show resolved Hide resolved
@linawolf linawolf merged commit f7a0623 into main Apr 15, 2024
4 checks passed
@linawolf linawolf deleted the task/mod-3 branch April 15, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants